Feat/1749 abort load package and raise exception on terminal errors in jobs #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
requested changes
Sep 3, 2024
There was a problem hiding this comment.
How we need to test it
- there are tests in dummy client that are testing abort feature, there just remove the flag. it is by default on
- make the other tests to pass by disabling the flag
look for raise_on_failed_jobs in the whole code
we use it to raise on load info, those are not needed anymore and can be removed (many of those)
I see that we set this flag in airflow helper. we should change the default there and also we never set it to false
there are other cases. you'll find them for sure
willi-mueller
force-pushed
the
feat/1749-abort-load-package-and-raise-exception-on-terminal-errors-in-jobs
branch
from
b305d9b to
932c160
Compare
willi-mueller
commented
Sep 9, 2024
docs/website/docs/reference/performance_snippets/performance-snippets.py
Show resolved
Hide resolved
willi-mueller
commented
Sep 9, 2024
…il_task_if_any_job_failed
…and calls to raise_on_failed_jobs()
willi-mueller
force-pushed
the
feat/1749-abort-load-package-and-raise-exception-on-terminal-errors-in-jobs
branch
from
b891bc1 to
2606217
Compare
…e. Refactors tests where necessary.
willi-mueller
force-pushed
the
feat/1749-abort-load-package-and-raise-exception-on-terminal-errors-in-jobs
branch
from
e851b84 to
864f642
Compare
willi-mueller
commented
Sep 9, 2024
willi-mueller
commented
Sep 9, 2024
…ption-on-terminal-errors-in-jobs
rudolfix
previously approved these changes
Sep 9, 2024
docs/website/docs/reference/performance_snippets/performance-snippets.py
Show resolved
Hide resolved
rudolfix
force-pushed
the
feat/1749-abort-load-package-and-raise-exception-on-terminal-errors-in-jobs
branch
from
83b9b15 to
aa66a49
Compare
rudolfix
force-pushed
the
feat/1749-abort-load-package-and-raise-exception-on-terminal-errors-in-jobs
branch
from
aa66a49 to
74697d8
Compare
rudolfix
deleted the
feat/1749-abort-load-package-and-raise-exception-on-terminal-errors-in-jobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues